Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sudo for travis builds #459

Closed
wants to merge 1 commit into from

Conversation

Alexander-N
Copy link
Member

Attempt to fix the kcov errors on travis. See
travis-ci/travis-ci#9061 and
https://blog.travis-ci.com/2018-01-08-travis-response-meltdown-spectre
for context.

#439

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #459 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   87.57%   87.66%   +0.08%     
==========================================
  Files          63       63              
  Lines        3355     3355              
==========================================
+ Hits         2938     2941       +3     
+ Misses        417      414       -3
Impacted Files Coverage Δ
src/buffer.rs 70.38% <0%> (+0.48%) ⬆️
src/err.rs 62.42% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661f472...dbd72cf. Read the comment docs.

@pganssle
Copy link
Member

@Alexander-N I think sudo: required is the default for Travis now, so I think this doesn't actually change anything.

@Alexander-N
Copy link
Member Author

Ah, too bad...

I think I'll re-trigger travis a couple of times just to make sure that the error still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants