ci: fix more ubuntu-24.04 failures #4610
Conversation
davidhewitt
added
CI-no-fail-fast
|
If this passes I will go straight to merge, as this is blocking everything else. |
| @@ -114,6 +114,7 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg(not(Py_GIL_DISABLED))] // https://github.com/python/cpython/issues/116738#issuecomment-2404360445 | |||
There was a problem hiding this comment.
We keep having a flaky failure on this test, from a quick look it seems to me that ZoneInfo is not thread-safe. cc @ngoldbaum
I've included here because CI is a bit deadlocked between this failure and the other fixes in this PR.
There was a problem hiding this comment.
Thanks for the heads up! I'll try to take a look at this and report upstream to CPython if the bug is there. Disabling the test on the free-threaded build makes sense if it's flaky.
There was a problem hiding this comment.
I can reproduce this as well as some other failures I haven't seen until now.
When I switch back to rc2, I don't see them, so there must have been a CPython change between rc2 and final that caused this to happen.
ping @colesbury since this looks like it's happening because of late changes in CPython right before the release.
There was a problem hiding this comment.
Oh no, I can reproduce it on rc2. I think I missed this on my prior passes over the tests because I wasn't passing --features=full in my cargo test command. Sorry for the noise Sam!
* ci: fix more ubuntu-24.04 failures * use 22.04 to test 3.7 * disable zoneinfo test on free-threading
* ci: fix more ubuntu-24.04 failures * use 22.04 to test 3.7 * disable zoneinfo test on free-threading
Looks like in a few jobs we hadn't used
actions/setup-pythonand were installing straight into the system environment, which is forbidden with newer pip on 24.04.