-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the module name for a pyclass #499
Conversation
Thanks, I think it's a really meaningful enhancement for us, but left comments about the coding. |
I forgot to push the latest commits with changelog expansion and tests for the module name, will do that when I can. |
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
- Coverage 87.8% 87.54% -0.26%
==========================================
Files 65 65
Lines 3435 3428 -7
==========================================
- Hits 3016 3001 -15
- Misses 419 427 +8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
======================================
Coverage 87.8% 87.8%
======================================
Files 65 65
Lines 3435 3435
======================================
Hits 3016 3016
Misses 419 419
Continue to review full report at Codecov.
|
Thanks! 🎉 |
Following #474, this PR adds an argument for
#[pyclass]
that lets the user specify the name of the module the class is part of. I also added the right module for all builtin types (eitherbuiltins
ordatetime
), with a few tests.Maintenance
cargo fmt
(This is checked by travis ci) ✅cargo clippy
and check there are no hard errors (There are a bunch of existing warnings; This is also checked by travis)You might want to run
tox
(pip install tox
) locally to check compatibility with all supported python versions. If you're using linux or mac you might find the Makefile helpful for testing.