Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject generics explicitly for #[pyclass] #503

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Reject generics explicitly for #[pyclass] #503

merged 1 commit into from
Jun 6, 2019

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Jun 4, 2019 •
edited
Loading

As per the discussion in #502, I tried to improve the error message for pyclasses with generic parameters.
In this PR, I also introduced the use of trybuild, which is a great library to test compile error messages for proc-macro functions.

@kngwyu kngwyu mentioned this pull request Jun 4, 2019
Closed
konstin
konstin approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using trybuild is really cool! The code changes look good, but we need to fix ci in some way before merging this.

@kngwyu
Copy link
Member Author

kngwyu commented Jun 5, 2019

I tried #[cfg(testkcovstopmarker)] for now

@kngwyu
Copy link
Member Author

kngwyu commented Jun 6, 2019

Now appveyor fails... 😢

@kngwyu kngwyu merged commit f2a7c64 into PyO3:master Jun 6, 2019
@rth rth mentioned this pull request Jun 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kngwyu @konstin