Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make &Py~ types unsendable #655

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Make &Py~ types unsendable #655

merged 3 commits into from
Oct 31, 2019

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Oct 27, 2019 •
edited
Loading

They should not be shared between threads.
E.g., prevents

    let s = PyString::new(py, "This object should not be shared >_<");
    py.allow_threads(|| {
        println!("{:?}", s);
    });

Resolves #652. #649

@kngwyu kngwyu mentioned this pull request Oct 27, 2019
Closed
@kngwyu kngwyu requested a review from konstin October 28, 2019 02:53
@kngwyu kngwyu merged commit 72debed into PyO3:master Oct 31, 2019
@kngwyu kngwyu mentioned this pull request Nov 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kngwyu @konstin