Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use struct.calcsize("P") rather than platform.machine() #830

Merged
merged 5 commits into from
Mar 29, 2020

Commits on Mar 25, 2020

  1. Configuration menu
    Copy the full SHA
    4a0c316 View commit details
    Browse the repository at this point in the history
  2. Use checkout@v2

    kngwyu authored and oconnor663 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    139a1e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. use struct.calcsize("P") rather than platform.machine()

    platform.machine() gives the wrong answer if you're running 32-bit
    Python on a 64-bit machine.
    
    The reason we don't use platform.architecture() here is that it's not
    reliable on macOS. See https://stackoverflow.com/a/1405971/823869.
    Similarly, sys.maxsize is not reliable on Windows. See
    https://stackoverflow.com/questions/1405913/how-do-i-determine-if-my-python-shell-is-executing-in-32bit-or-64bit-mode-on-os/1405971#comment6209952_1405971
    and https://stackoverflow.com/a/3411134/823869.
    
    Also use CARGO_CFG_TARGET_POINTER_WIDTH rather than inferring the Rust
    target pointer width from CARGO_CFG_TARGET_ARCH.
    oconnor663 committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    f3876a9 View commit details
    Browse the repository at this point in the history
  2. avoid using platform.architecture() to detect 32-bit-ness in datetime…

    … tests
    
    Same reasoning as the previous commit.
    oconnor663 committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    9e23476 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. Configuration menu
    Copy the full SHA
    d2c07a8 View commit details
    Browse the repository at this point in the history