Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing explicit None to pyfunction with default #936

Merged
merged 1 commit into from
May 18, 2020
Merged

Fix passing explicit None to pyfunction with default #936

merged 1 commit into from
May 18, 2020

Conversation

davidhewitt
Copy link
Member

Fixes #932

@davidhewitt davidhewitt mentioned this pull request May 17, 2020
Closed
kngwyu
kngwyu approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@kngwyu kngwyu merged commit c393d4a into PyO3:master May 18, 2020
@davidhewitt davidhewitt deleted the optional-bool branch December 24, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot give Option function argument a default value but still pass None explicitly
2 participants
@davidhewitt @kngwyu