Use Version, VersionSpecifiers and Requirement from PEP 440 and PEP 508 parser #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…08 parser Using crates.io releases is currently blocked on PyO3/pyo3#2786
|
LGTM, I guess we should merge this after PyO3/pyo3#2786 since we can't publish to crates.io and you need to use git dep anyway? |
|
yes; i'm not entirely sure how to proceed though since PyO3/pyo3#2786 seems stalled but i need it for pep440_rs and i don't want to publish a fork |
|
If the Python API surface isn't big, maybe just use wrapper types to expose to Python for now and feature gate them in a separate module instead. It's a bit tedious, but hey it works. |
|
:/ done |
messense
approved these changes
Mar 30, 2023
|
Published in v0.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we actually parse
version,requires,dependencies,optional_dependencies, both validating them and allowing the user to actually use these field. If we also update of maturin, this prevents bugs like mozilla/bleach#655.Using crates.io releases is currently blocked on PyO3/pyo3#2786