Skip to content

Commit

Permalink
Extend changelog w.r.t. capsule-based dynamic borrow checking.
Browse files Browse the repository at this point in the history
  • Loading branch information
adamreichold committed Dec 31, 2022
1 parent 86551fd commit f52f4a6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Unreleased
- Add conversions from and to datatypes provided by the [`nalgebra` crate](https://nalgebra.org/). ([#347](https://github.com/PyO3/rust-numpy/pull/347))
- Drop our wrapper for NumPy iterators which were deprecated in v0.16.0 as ndarray's iteration facilities are almost always preferable. ([#324](https://github.com/PyO3/rust-numpy/pull/324))
- Dynamic borrow checking now uses a capsule-based API and therefore works across multiple extensions using PyO3 and potentially other bindings or languages. ([#361](https://github.com/PyO3/rust-numpy/pull/361))

- v0.17.2
- Fix unsound aliasing into `Box<[T]>` when converting them into NumPy arrays. ([#351](https://github.com/PyO3/rust-numpy/pull/351))
Expand Down
2 changes: 1 addition & 1 deletion src/borrow/shared.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ fn insert_shared(py: Python) -> PyResult<*const Shared> {
let capsule: &PyCapsule = match module.getattr("_RUST_NUMPY_BORROW_CHECKING_API") {
Ok(capsule) => capsule.try_into()?,
Err(_err) => {
let flags = Box::into_raw(Box::new(BorrowFlags::default()));
let flags: *mut BorrowFlags = Box::into_raw(Box::default());

let shared = Shared {
version: 1,
Expand Down

0 comments on commit f52f4a6

Please sign in to comment.