Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since npy_char is c_char which can be u8 or i8, we cannot unconditionally use negation. #296

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Since npy_char is c_char which can be u8 or i8, we cannot unconditionally use negation. #296

merged 1 commit into from
Mar 17, 2022

Conversation

adamreichold
Copy link
Member

Closes #295

@adamreichold adamreichold mentioned this pull request Mar 16, 2022
Closed
antimora
antimora reviewed Mar 17, 2022
View reviewed changes
Copy link

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build works but I have a small question/comment about the value.

src/npyffi/flags.rs Outdated Show resolved Hide resolved
@adamreichold adamreichold changed the base branch from main to release-0.16 March 17, 2022 11:20
@adamreichold adamreichold merged commit bdf9d53 into release-0.16 Mar 17, 2022
@adamreichold adamreichold deleted the fix-npy-aligned-struct branch March 17, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antimora antimora antimora left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to compile on linux aarch64
2 participants
@adamreichold @antimora