Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal support for BFloat16 dtype. #381

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Add minimal support for BFloat16 dtype. #381

merged 2 commits into from
Jun 22, 2023

Conversation

adamreichold
Copy link
Member

@adamreichold adamreichold commented Jun 21, 2023 •
edited
Loading

Closes #380

@adamreichold adamreichold mentioned this pull request Jun 21, 2023
Closed
@adamreichold
Copy link
Member Author

The issue with the "careful" job seems unrelated to the change at hand.

@adamreichold adamreichold marked this pull request as ready for review June 21, 2023 10:37
@adamreichold
Copy link
Member Author

@kngwyu Not sure what to do about tests here? Ship it without any tests? Install Tensorflow in the CI? Something else?

@kngwyu
Copy link
Member

kngwyu commented Jun 22, 2023 •
edited
Loading

How about using ml_dtypes? I have no experience with this, but it looks suitable for CI because it only depends on numpy.

@adamreichold
Copy link
Member Author

How about using ml_dtypes? I have no experience with this, but it looks suitable for CI because it only depends on numpy.

Yes, this is a nice self-contained one and the CI seems to be happy using it.

What do you think about the change itself? Would you be ok with merging while the careful job is still broken due to the rust-toolchain action being unable to install Rust nightly?

kngwyu
kngwyu approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tests/array.rs Show resolved Hide resolved
@kngwyu
Copy link
Member

kngwyu commented Jun 22, 2023

Would you be ok with merging while the careful job is still broken due to the rust-toolchain action being unable to install Rust nightly?

I'm personally OK to go ahead, but just waiting seems also OK if the nightly will come back soon. (I hope it will be fixed tomorrow, though sometimes it can take some time...

@adamreichold
Copy link
Member Author

I'm personally OK to go ahead, but just waiting seems also OK if the nightly will come back soon. (I hope it will be fixed tomorrow, though sometimes it can take some time...

Yeah, let's wait...

@adamreichold adamreichold merged commit 08510a3 into main Jun 22, 2023
@adamreichold adamreichold deleted the bfloat16 branch June 22, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support BF16 in Rust Numpy
2 participants
@adamreichold @kngwyu