Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate PyArray contructors to Bound API (Part 2) #418

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Mar 25, 2024

Following #416

This continues the migration of PyArray constructors to the Bound API. This migrates with PyArray::{from_slice, arange}.

src/npyffi/array.rs Outdated Show resolved Hide resolved
src/array.rs Outdated Show resolved Hide resolved
@adamreichold
Copy link
Member

Some doctests seem to fail to compile. You check the doc build using ./x.py d.

Please also have a look whether the benchmarks need adjustments. They are included in the default ./x.py action.

@Icxolu
Copy link
Contributor Author

Icxolu commented Mar 25, 2024

Please also have a look whether the benchmarks need adjustments. They are included in the default ./x.py action.

Sure, I'll check again once #417 is merged

@Icxolu
Copy link
Contributor Author

Icxolu commented Mar 25, 2024

Rebased and updated benchmarks. For reference: The deprecation warnings in the benchmarks did not show up on ./x.py for me

@adamreichold
Copy link
Member

The deprecation warnings in the benchmarks did not show up on ./x.py for me

Ah yes, the script checks if a nightly toolchain is used and builds the benchmarks only in this case (as they require std's unstable test feature).

@adamreichold adamreichold merged commit c2a3c39 into PyO3:main Mar 25, 2024
33 of 35 checks passed
@Icxolu Icxolu deleted the constructors-2 branch March 25, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants