Support ndarray 0.16 #439
Support ndarray 0.16 #439
Conversation
|
This PR is blocked on rust-ndarray/ndarray-linalg#379 |
|
Previous discussion about ndarray 0.16, rust-numpy and ndarray-linalg: rust-ndarray/ndarray#1374 |
|
Ok, that comment was maybe not super helpful - ndarray 0.16 got a few more changes since that happened. But I think it points out that ndarray-linalg doesn't need to be a strict blocker for this update. |
|
I see the main argument: Allow the deprecation and let the end user deal with the dependency through their lockfile. I am not sure how to create a lockfile with the right dependency through cargo invocations, but checking in the lockfile should hopefully work |
|
Some more deprecated methods were removed in ndarray post adamreichold's test. Hoping ndarray-linalg can be tested using ndarray 0.15 only suggested. With that said, we should be able to get a solution (to update) ndarray-linalg sooner or later.. |
|
ndarray 0.15 has an MSRV of 1.49, so I think we can limit to 0.15 and 0.16 here. (We are about to move to MSRV 1.63 as per #449.) |
|
What’s the status of this PR now? |
|
Just needs someone to pick up and finish off as per my above comment - the MSRV bump is now applied on |
|
@davidhewitt Bumped lower ndarray version in a new commit |
magnusuMET
force-pushed
the
ndarray_0.16
branch
from
1041c53
to
abe7de5
Compare
magnusuMET
force-pushed
the
ndarray_0.16
branch
from
abe7de5
to
f4849bc
Compare
|
@davidhewitt Let's try again, including the changes in #451 |
There was a problem hiding this comment.
This looks good to me, thanks very much @magnusuMET for the swift pick-up once we decided what to do here!
|
thanks everyone for working on this 💯 |
### What - Add a new type helper for IndexValues (in general some variation of this will be useful for other APIs) - Added a dependency on `numpy` package for ArrayLike functionality - `numpy` has an old dep on ndarray. - This has already been fixed but not yet released: PyO3/rust-numpy#439 - ChunkedArrays are sadly are more complicated (see the note in: https://docs.rs/arrow/latest/arrow/pyarrow/index.html) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7670?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7670?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7670) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Fixes #438