Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.10.0 #448

Merged
merged 1 commit into from
Aug 3, 2024
Merged

release: 1.10.0 #448

merged 1 commit into from
Aug 3, 2024

Conversation

davidhewitt
Copy link
Member

No description provided.

@alex
Copy link
Contributor

alex commented Jul 2, 2024

I'm concerned that #429 is going to break cryptography's build.

https://github.com/pyca/cryptography/blob/main/src/rust/cryptography-cffi/build.rs#L29-L37

This relies on running in the same venv where the build requirements were installed, because that Python script imports cffi.

Not sure if there's a way to write that script that's compatible with this change (which seems quite deserirable!)

@davidhewitt
Copy link
Member Author

Hmm, good point. I think in general the fact that #429 is unconditionally breaking build isolation seems problematic

cc @messense; might also be a problem for maturin?

Not sure what to do here, the obvious solution is to revert #429 but maybe there's a better solution as you say. Avoiding needless recompilation would be great. Probably we have to move towards PYO3_ENVIRONMENT_SIGNATURE like maturin does.

Either way, setuptools-rust ran fine on 3.13 without changes so holding up the release a little bit while we work this out isn't going to block 3.13 testing.

@messense
Copy link
Member

messense commented Jul 2, 2024

cc @messense; might also be a problem for maturin?

yes, we've got a report in maturin related to this, I've changed it to require setting a env var to opt-in the behavior in PyO3/maturin#2134

@davidhewitt
Copy link
Member Author

Ok, I think this should be better now with #458 merged.

@alex
Copy link
Contributor

alex commented Aug 2, 2024

Sounds great.

@davidhewitt
Copy link
Member Author

This is now live 👍

@davidhewitt davidhewitt merged commit 7b0dd24 into main Aug 3, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants