Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider the planning horizon for biomass potentials input #1311

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

p-glaum
Copy link
Contributor

@p-glaum p-glaum commented Sep 19, 2024

build_sector.smk: always consider the planning horizon for biomass potentials input in prepare_sector_network

Changes proposed in this Pull Request

The problem was that for overnight, not the planning horizon was considered for the biomass potential but the year set in the config under biomass. This led to the unwanted behavior that one could not do a 2050 optimization with the biomass potentials from ENSPRESO for 2030 and without unsustainable biomass.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
nodal_capacities.csv ⚠️ NaN mismatch
nodal_supply_energy.csv ⚠️ NaN mismatch
costs.csv ⚠️ NaN mismatch
cfs.csv ⚠️ NaN mismatch
nodal_cfs.csv ⚠️ NaN mismatch
nodal_costs.csv ⚠️ NaN mismatch
capacities.csv ⚠️ NaN mismatch
supply.csv ⚠️ NaN mismatch
prices.csv ⚠️ NaN mismatch
supply_energy.csv ⚠️ NaN mismatch
energy.csv ⚠️ NaN mismatch
price_statistics.csv ✅ Almost equal 0.000 0.35
curtailment.csv ✅ Almost equal 0.000 0.18
metrics.csv ✅ Almost equal 0.004 0.16
weighted_prices.csv ✅ Almost equal 0.558 0.41
market_values.csv ✅ Almost equal 0.000 0.10

NRMSE: Normalized (min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized Data (min-max
Status Threshold: MAE (norm) > 0.05 and NRMSE > 2

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix_biomass_input (40efa65) with master (38f2dc7).
Branch is 3 commits ahead and 0 commits behind.
Last updated on 2024-09-19 11:07:28 CEST.

@fneum
Copy link
Member

fneum commented Sep 19, 2024

This is the intended behavior that you can use 2030 biomass potentials for 2050 runs.

@p-glaum
Copy link
Contributor Author

p-glaum commented Sep 19, 2024

I think we are talking about different things here. You can still optimize a 2050 year with biomass potentials of 2030. It is only for the unsustainable fraction which is taken from year 2050.

@fneum
Copy link
Member

fneum commented Sep 24, 2024

Alright, I think I got it now. Will you do the adjustment we talked about, using planning horizon as key and ENSPRESO potential year as values in the config.yaml? Then, we can merge.

biomass:
  year:
    2020: 2020
    2025: 2025
    2030: 2030
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants