Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs build in readthedocs #658

Merged
merged 9 commits into from
May 7, 2023
Merged

fix docs build in readthedocs #658

merged 9 commits into from
May 7, 2023

Conversation

pz-max
Copy link
Collaborator

@pz-max pz-max commented May 7, 2023

pypsa-eur docs build is failing on readthedocs < see here

Changes proposed in this Pull Request

PyPSA-Earth docs are passing so I add here changes that should work on PyPSA-Eur as well:

Tested these locally, and below you can also see that the readthedocs build is working

Thanks for the really cool new docs theme :)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • A release note doc/release_notes.rst is added.

@pz-max pz-max requested a review from fneum May 7, 2023 13:34
@pz-max
Copy link
Collaborator Author

pz-max commented May 7, 2023

Docs are passing now. Ready to merge.

@fneum
Copy link
Member

fneum commented May 7, 2023

Thanks Max! It does not seem to pass the graphviz elements:

https://pypsa-eur--658.org.readthedocs.build/en/658/tutorial_sector.html

@pz-max
Copy link
Collaborator Author

pz-max commented May 7, 2023

@fneum, you are right. A fix is coming 👍

@pz-max
Copy link
Collaborator Author

pz-max commented May 7, 2023

@fneum looks good now. Thanks INSTAGRAM https://github.com/Instagram/LibCST/pull/751/files 🥇

@fneum fneum merged commit 1fbe971 into PyPSA:master May 7, 2023
@pz-max pz-max deleted the doc-patch branch May 7, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants