Add dribbled past duel type

[DriesDeprest]

PR related to #257.

We introduced A DRIBBLED_PAST DuelType and added the TACKLE qualifier to duels for Opta & StatsBomb.

[DriesDeprest]

I think the checks failed due to a network issue. @JanVanHaaren @koenvo could you re-run the checks?

[JanVanHaaren]

@DriesDeprest Done!

[JanVanHaaren]

@probberechts Would you mind having a quick look at this pull request?

[probberechts]

Would it be possible to add the TACKLE qualifier also to the Wyscout deserializers such that a "tackle" is at least consistently defined everywhere?

Intuitively, there should be a DRIBBLED_PAST event for each successful dribble. Would it be possible to write a test for this? I am not familiar with the StatsBomb "Dribbled Past" and Opta "Challenge" events and this would convince me that my interpretation of their documentation is correct.

[JanVanHaaren]

Intuitively, there should be a DRIBBLED_PAST event for each successful dribble. Would it be possible to write a test for this? I am not familiar with the StatsBomb "Dribbled Past" and Opta "Challenge" events and this would convince me that my interpretation of their documentation is correct.

In StatsBomb's event data, the Dribbled Past event is typically paired with a completed Dribble event but can also be paired with an incompleted Dribble event. For example, the data for one of our recent games includes one Dribbled Past event that is paired with an incompleted Dribble event. The overrun flag for the Dribble event is set to true though. However, like you suggested, a completed Dribble event always seems to be paired with a Dribbled Past event.

{
  "id": "dd23312c-596e-4f63-b5a0-b75967299e9d",
  "type": {
    "id": 14,
    "name": "Dribble"
  },
  "related_events": [
    "17d2402c-0685-4dba-9e7b-dbeb055d02e8"
  ],
  "dribble": {
    "overrun": true,
    "outcome": {
      "id": 9,
      "name": "Incomplete"
    }
  }
}

{
  "id": "17d2402c-0685-4dba-9e7b-dbeb055d02e8",
  "type": {
    "id": 39,
    "name": "Dribbled Past"
  },
  "related_events": [
    "dd23312c-596e-4f63-b5a0-b75967299e9d"
  ]
}

[DriesDeprest]

Would it be possible to add the TACKLE qualifier also to the Wyscout deserializers such that a "tackle" is at least consistently defined everywhere?

Will do this!

How Intuitively, there should be a DRIBBLED_PAST event for each successful dribble. Would it be possible to write a test for this?

How would you implement this?
For StatsBomb we can use the related_event_ids property to check for all successful dribbles whether one of their related events is an event with the DRIBBLED_PAST qualifier
But for Opta & Wyscout we don't have these related event ID's, how would you go about this?

[probberechts]

How would you implement this?

count(type = DRIBBLED_PAST) == count(type = DRIBBLE & outcome = SUCCESS)

[koenvo]

@DriesDeprest any update on this one?

[DriesDeprest]

Not really, I've had other priorities. I'll let you know if it changes.