-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selenium container opera chrome #85
Add selenium container opera chrome #85
Conversation
@sydoluciani when I run
Followed by many errors of:
I'm on I set all the environment variables as described in |
Perhaps this PR needs to be rebased on |
Yeah, I think that is the issue. When I check out |
Please try export URL=http://your_ip_address:8522 instead of export URL=http://localhost:8522 and let me know. |
None of the following worked for
I'm running all this locally on my iMac. What should I expect to see? Should a web browser launch? |
I had to restart Docker Desktop (docker machine on macOS). That seems to have freed up whatever was messing up networking. The only value of It does take a while to start up. I can monitor activity in Docker Desktop. All the tests ran successfully for Firefox. I'll try the other two browsers next. |
Is that pretty much what you expected? I need to update |
Yes, localhost didn't work for me either, and the rest of ip addresses probably related to Docker network and not your host ip address. We should rewrite those failed tests to make them pass accross all 3 browsers. |
in contributing.md, we can mention that Firefox is the mainstream and all tests has to pass to accept pull requests, but if any one wants to contribute, they can rewrite failed tests to work accross all 3 browsers. we mentioned this end of the contributing.md about chrome. that section needs an update. |
OK, I'm going to merge this PR because it accomplishes containerization. If you pull I will create a new issue for the failed tests. |
I just pushed a commit to both |
@stevepiercy OK, Thanks for the reminder. I did clone and started from scratch and checked the diff to make sure it is synced on both upstream and origin. was there any discrepancy in my recent pull requests. When I pull from upstream, I get a message : git config pull.rebase false # merge (the default strategy) Which of the above do you set in your config ? |
Merge is my default. Sometimes I will rebase when I want to include those commits when that work will effect the work I am about to do. |
Adding Selenium Opera and Chrome Containers and test if travis picks the right block.