Remove __nonzero__ methods
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
reviewed
Aug 20, 2022
| @@ -224,13 +222,11 @@ def __len__(self): | |||
| else: | |||
| return self.strbuf.__len__() | |||
|
|
|||
| def __nonzero__(self): | |||
| def __bool__(self): | |||
| # use self.__len__ rather than len(self) FBO of not getting | |||
There was a problem hiding this comment.
Presumably we don't need __bool__ either:
>>> class Foo:
... def __init__(self, x): self.x = x
... def __len__(self): return self.x
...
>>> bool(Foo(1))
True
>>> bool(Foo(5))
True
>>> bool(Foo(0))
False
There was a problem hiding this comment.
That might have consequences which I am not able to judge.
Skimming the code it seems that now you can have a length FileBasedBuffer instance which is True.
Removing the __bool__ method this will change to False.
But, as said, I am not much in to this code to say if thic can be a good or bad thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__nonzero__is not used in python3.And since
setup.pydeclares python3.7 support only, I think it is safe to remove these methods.I found this while working on
typeshedtypes for this project 🙂