Hiding Of Skip Button Is Now Handled By A Visibility Widget So It Doesn't Jump Around

[impure]

This issue shows the problem:

#118

They solved it some other way. This pull request solves it by replacing the widget with a visibility widget allowing it to maintain its size even if hidden.

[ghenry]

Thanks @impure

Looks good!

Appreciate you taking the time to do this.

Gavin.

[ghenry]

Can you look at the docs to update the READme with this? I know it's asking a lot, but would be much appreciated.

[impure]

Do you mean the Changelog? I didn't change the API so I don't know what to change in the readme.

[ghenry]

Ah, nevermind. All good. Thanks for the clarification.

[EnduringBeta]

Shoutout to anyone else whose integration tests broke because of this change to the Skip button. ;) Totally reasonable and good update!

[ghenry]

Ah, apologies. Did you get them sorted then? Anything you can share for others on here?

…

On Tue, 29 Nov 2022, 22:56 Ross Llewallyn, ***@***.***> wrote: Shoutout to anyone else whose integration tests broke because of this change to the Skip button. ;) Totally reasonable and good update! — Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABG66AMXW2QEUS5Z2ABXP3WK2CZHANCNFSM5YPMGHMA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[EnduringBeta]

Absolutely. It's a pretty simple change. Just add hitTestable() on the end of the Skip Finder if it stops working.

// Skip button is made invisible, not completely removed
static final Finder _skipFinder = find.text('Skip').hitTestable();
...
expect(_skipFinder, findsNothing);
...
expect(_skipFinder, findsOneWidget);

[ghenry]

Thanks. Much appreciated!

…

On Wed, 30 Nov 2022, 00:11 Ross Llewallyn, ***@***.***> wrote: Absolutely. It's a pretty simple change. Just add hitTestable() on the end of the Skip Finder if it stops working. // Skip button is made invisible, not completely removedstatic final Finder _skipFinder = find.text('Skip').hitTestable(); ...expect(_skipFinder, findsNothing); ...expect(_skipFinder, findsOneWidget); — Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABG66GQQCUJFGDZ6PKOXSLWK2LT7ANCNFSM5YPMGHMA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[ghenry]

Actually, I've only very recently taken over maintenance of this project. I've added a few basic tests https://github.com/Pyozer/introduction_screen/tree/master/test/widget If there are any you could contribute to the main project or for the example app, that would be amazing!