Update Gradle and Kotlin versions #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I had to do this myself yesterday too. PR approved! Thank you for taking the time to make a contribution @youssefmaly Much appreciated!!! |
ghenry
requested changes
Nov 23, 2022
|
Sure. I will do that. Thanks for the cool package.
…On Wed, Nov 23, 2022 at 6:47 PM Gavin Henry ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In example/android/build.gradle
<#145 (comment)>
:
> classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+ classpath 'com.google.gms:google-services:4.3.10'
This isn't needed unless we are using Firebase/FlutterFire etc.
------------------------------
In example/android/build.gradle
<#145 (comment)>
:
> classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+ classpath 'com.google.gms:google-services:4.3.10'
Want to do a new PR and remove it?
—
Reply to this email directly, view it on GitHub
<#145 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW7XDPKMVUWVA6MC5UAJY7DWJZDB5ANCNFSM6AAAAAASHQWXCU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Not mine, just helping out :) |
Thank you for your contribution! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the example to work on Android devices.