Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some changes and fixes to auto scroll #186

Merged
merged 6 commits into from
Jun 8, 2023
Merged

some changes and fixes to auto scroll #186

merged 6 commits into from
Jun 8, 2023

Conversation

Macacoazul01
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ghenry ghenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change removing those options?

@Macacoazul01
Copy link
Contributor Author

Unfortunately it is kind of...

The behavior of the package will remain as the safe list replace these options, but as they will be removed, it can break some users code.

@Macacoazul01
Copy link
Contributor Author

As there is already the dots to int breaking that wasn't added officially to a version, I took the opportunity to do this one too

@ghenry
Copy link
Collaborator

ghenry commented Jun 8, 2023

Didn't we revert that and want to do a breaking change major version? Can't recall.

@Macacoazul01
Copy link
Contributor Author

Nope
It was merged (pr #180)

@ghenry ghenry merged commit f25bbbd into Pyozer:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants