Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1293 Add customizable TOC title class #1294

Merged
merged 7 commits into from
Aug 11, 2023
Merged

Fix #1293 Add customizable TOC title class #1294

merged 7 commits into from
Aug 11, 2023

Conversation

pauloxnet
Copy link
Contributor

No description provided.

@waylan waylan added the needs-review Needs to be reviewed and/or approved. label Sep 12, 2022
@waylan
Copy link
Member

waylan commented Sep 12, 2022

This appears to be an implementation of the feature requested in #1293. What happens here depends on what decision is made there.

@waylan
Copy link
Member

waylan commented Apr 18, 2023

Given the decision made in #1293, I will not be accepting this as-is. However, I am not opposed to including the new config option to allow the user to define the class assigned to the title. After all, we already allow various other classes to be set by the user. Might as well include this one too.

If this is updated (with all checks passing), then I would be happy to accept it. If no action is taken, it will likely be closed.

@waylan waylan added requires-changes Awaiting updates after a review. and removed needs-review Needs to be reviewed and/or approved. labels Apr 18, 2023
@pauloxnet
Copy link
Contributor Author

I'll try to work on that in may because tomorrow I'm leaving to go to PyCon US.

@pauloxnet pauloxnet force-pushed the feature/toc-details branch 2 times, most recently from eba0fc9 to 24bd645 Compare July 26, 2023 07:28
@pauloxnet pauloxnet changed the title Fix #1293 Support more customizable toc Fix #1293 Add customizable TOC title class Jul 26, 2023
@pauloxnet
Copy link
Contributor Author

@waylan I rebased this PR and left only the customizable TOC title class.
I renamed this PR because is changed a lot from my original idea.

@waylan waylan added this to the Version 3.5 milestone Jul 26, 2023
@waylan
Copy link
Member

waylan commented Aug 7, 2023

The tests will need to all be passing before we can accept this. Also, the release notes and the documentation need to be updated appropriately.

@pauloxnet
Copy link
Contributor Author

The tests will need to all be passing before we can accept this. Also, the release notes and the documentation need to be updated appropriately.

@waylan I fixed test failures and updated the documentation

@waylan waylan added approved The pull request is ready to be merged. and removed requires-changes Awaiting updates after a review. labels Aug 11, 2023
@waylan waylan merged commit 25b64df into Python-Markdown:master Aug 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waylan waylan waylan approved these changes

Assignees
No one assigned
Labels
approved The pull request is ready to be merged.
Projects
None yet
Milestone
Version 3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@pauloxnet @waylan