-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1353: Update list of empty HTML tags. #1354
Conversation
Python 3.11 already includes the updated list of empty HTML elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. However, we need a note added to the change log.
I don't think we need to add a test. Current tests are here. We are currently only testing one empty tag (hr
). That is probably sufficient.
Note that we can ignore the failing pypy37 test env as that failure is related to the tooling (a tox call is raising an error). Our code never even runs. We will need to track that down separately.
The 3.5 release notes are now available. If a note is added there, this will be merged. |
Thank you, I will try to fix it today. I was simply a bit confused about the requirement (the actual how-to-that part), and got distracted. |
There you go! I updated the changelog. Thanks for your work and your patience. |
I left existing tags in, even the deprecated ones. This fixes #1353