Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1353: Update list of empty HTML tags. #1354

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

nicbou
Copy link
Contributor

@nicbou nicbou commented Jun 29, 2023

I left existing tags in, even the deprecated ones. This fixes #1353

@nicbou nicbou changed the title Update list of empty HTML tags. Fixes #1353 Fix #1353: Update list of empty HTML tags. Jun 29, 2023
Python 3.11 already includes the updated list of empty HTML elements.
Copy link
Member

@waylan waylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. However, we need a note added to the change log.

I don't think we need to add a test. Current tests are here. We are currently only testing one empty tag (hr). That is probably sufficient.

Note that we can ignore the failing pypy37 test env as that failure is related to the tooling (a tox call is raising an error). Our code never even runs. We will need to track that down separately.

@waylan waylan added the requires-changes Awaiting updates after a review. label Jun 30, 2023
@waylan waylan added this to the Version 3.5 milestone Jul 24, 2023
@waylan
Copy link
Member

waylan commented Aug 7, 2023

The 3.5 release notes are now available. If a note is added there, this will be merged.

@nicbou
Copy link
Contributor Author

nicbou commented Aug 8, 2023

Thank you, I will try to fix it today. I was simply a bit confused about the requirement (the actual how-to-that part), and got distracted.

@nicbou
Copy link
Contributor Author

nicbou commented Aug 10, 2023

There you go! I updated the changelog. Thanks for your work and your patience.

@waylan waylan merged commit acdbdc1 into Python-Markdown:master Aug 11, 2023
16 checks passed
@waylan waylan added approved The pull request is ready to be merged. and removed requires-changes Awaiting updates after a review. labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The pull request is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete list of empty HTML tags leads to invalid HTML
2 participants