Heading in list #1436
Merged
Heading in list #1436
+144
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a weird edge case. Normally, detabbing would be handled by the `ListIndentProcessor`. However, in this one case, that class's `get_level` method would need to return a different result than in any other case. As there is no way to easily determine this specific case from that class, we make the adjustment directly in the `HashHeaderProcessor` class. Fixes Python-Markdown#1433.
|
This is ready to go. Turns out the first item in a list was being parsed differently because the list parser does not look ahead and it doesn't know it is in a loose list until it gets to the second list item. The fix here just detects that its in the second (or later) item and adjusts the content |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a start at a fix for #1433. So far I have tests, one of which is failing.