Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set dataowner / provider if Null in Database #36

Open
sjib opened this issue Aug 25, 2021 · 3 comments
Open

How to set dataowner / provider if Null in Database #36

sjib opened this issue Aug 25, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@sjib
Copy link
Contributor

sjib commented Aug 25, 2021

datenherr=getattr(row.fk_dataowner__REL, "name", "unknown"), # TODO : is unknown ok ?

@olivierdalang Do I understand right, that it is set to "unknown" if is Null in QGEP at the moment
wastewater_structure_fk_dataowner_provider_null
?

@sjib sjib added the question Further information is requested label Aug 25, 2021
@olivierdalang
Copy link
Collaborator

Yes that should be the current behavior.

Can users not just fix that in their data if actually the owner is actually known ?

@sjib
Copy link
Contributor Author

sjib commented Aug 25, 2021

Yes, that would be the correct way to correct the data.

In the INTERLIS models the value "unknown" has a special meaning and is not the same as an empty (or Null) value. "unknown" means that someone has invested time and money to find out about a certain attribute, but did not find another value. Therefore writing "unknow" would imply that you did not find out who is the dataowner / provider. So my question is whether we should not better leave it empty as we do now also with the other attributes, so it would be clearer, that this data is missing.

In the next release (2020) of SIA405 Abwasser / VSA-DSS these two attributes will also be referenced to organisation (as e.g. owner) in the INTERLIS model and will therefore also be treated as reference keys. The user then has to fill them out anyway to have a valid export.

@olivierdalang
Copy link
Collaborator

We can leave it empty, but this will make the output of the demo dataset invalid again. So we'd have to make a new release of the demo dataset with populated dataowner/dataprovider columns. I suggest to leave that for a further improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants