This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Some tidying to the fix class names code #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomphp
force-pushed
the
refactor/fix-class-names-tidied-up
branch
from
850b8eb
to
51206e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some simple refactoring and optimisation. I did it while investigating #55 so I could follow the code. Even though the issue eventually turned out to be non-existent I thought I'd submit these changes.
The changes to the test suite only amount to changes in the order as the patches are generated in a different way, the content is still exactly the same. As I said before I think this indicates that a better approach to the tests would be good.
There was also some code in there which "worked around" the previous patch generation code, this was no longer required with the new code.