-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modules): Scaleform class #584
base: main
Are you sure you want to change the base?
feat(modules): Scaleform class #584
Conversation
Introduces a scaleform class, based upon ox lib classes, to make scaleforms both easier to read and use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by this API. I think it would help if all the methods of this class have a leading verb in the name. I also don't think this API is abstracting away enough of the lower level complexities of scaleform. Focus the API on how the user wants to interact with scaleform, and hide the way it actually works.
For an example API that does do some abstractions, see this C# scaleform class https://github.com/citizenfx/fivem/blob/master/code/client/clrcore/External/Scaleform.cs
for how this looks in code. it cannot get more simplier while still giving all scaleform functionality to the user from my latest commit, the only one without a verb, is method, which really doesnt need one |
Co-authored-by: David Malchin <[email protected]>
Co-authored-by: David Malchin <[email protected]>
Description
Introduces a scaleform class, based upon ox lib classes, to make scaleforms both easier to read and use
Checklist