-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use external state management #593
base: main
Are you sure you want to change the base?
Use external state management #593
Conversation
53abf52
to
124ea79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would setting the hunger and thirst decay to 0 accomplish the same thing as this PR?
No, because:
|
One of my concerns is breaking our existing API behavior. Other resources set metadata or a statebag and expect it to be synced and updated. Maybe dropping thirst/hunger should be moved to config rather than being hard coded. I'd like to find a way to add compatibility for your resource without changing the behavior for existing Qbox integrations. |
I understand the issue. |
change done in playerstates. Now it accept changes done directly in metadata or statebag |
Description
Checklist