Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renew example codes in README #1806

Closed
hhorii opened this issue May 10, 2023 · 12 comments · Fixed by #1831
Closed

Renew example codes in README #1806

hhorii opened this issue May 10, 2023 · 12 comments · Fixed by #1831
Assignees
@davidlearn
Labels
documentation Something is not clear or error in description good first issue Good for newcomers

Comments

@hhorii
Copy link
Collaborator

hhorii commented May 10, 2023

Current example codes in README prints deprecation warnings and does not work.

  • qiskit.providers.ibmq is deprecated
  • ibmq_athens is not available

We need to update the code.
@hhorii hhorii added good first issue Good for newcomers documentation Something is not clear or error in description labels May 10, 2023
@Mostafa-Atallah2020
Copy link

Hi @hhorii ,i would like to work on this assign me please

@alt-shreya
Copy link

@hhorii Can I work on this task as well?

@andre-a-alves andre-a-alves mentioned this issue May 27, 2023
Closed
@andre-a-alves
Copy link

andre-a-alves commented May 27, 2023 •
edited
Loading

Will any available backend do? My PR uses ibmq_manila since it's the only 5-qubit free system that's a Falcon r5.11L.

Also, this PR was submitted as part of Unitary Fund's Unitary Hack event. If my PR is accepted, please assign me to the issue so the event's bots could associate me with this issue. Thank you :-)

@davidlearn
Copy link
Contributor

davidlearn commented May 27, 2023 •
edited
Loading

Hi @hhorii, My PR 1831 fixed the problem first, 5 hours earlier than another PR 1832. If my PR is accepted, the Unitary Hackthon bounty should be mine first. This is my first PR and I did not know that I had to mention issue #1806 in my PR. Thanks.

@davidlearn davidlearn mentioned this issue May 27, 2023
Merged
@andre-a-alves
Copy link

Sorry, @davidlearn I hadn't seen your PR since the issue wasn't linked. I was not trying to ruffle any feathers - I just thought it was still an unsolved issue.

@davidlearn
Copy link
Contributor

davidlearn commented May 27, 2023 •
edited
Loading

That is my first PR to fix an issue. What is the normal way to link a PR to an issue?

@davidlearn
Copy link
Contributor

@andre-a-alves It is OK. Hope that we closed the issue. There must be a better way to update all examples when a new release affect certain functions.

@andre-a-alves
Copy link

That is my first PR to fix an issue. What is the normal way to link a PR to an issue?

You just need to include the issue number after a hashtag in the PR description or a comment. I think the clearest way is to say "closes," "fixes," or "addresses" as well. So, for example, in my PR for this issue, I included "Closes #1806". That links the PR to the issue and lets the reviewer know what the PR is for.

davidlearn referenced this issue in davidlearn/qiskit-aer May 30, 2023
@davidlearn
Fix REAM Qiskit#1896 qiskit.providers.ibmq is deprecated;
4256dc3
@davidlearn
Copy link
Contributor

PR #1831 fixed #1806 using FakeManilaV2 fake backend.

@mergify mergify bot closed this as completed in #1831 Jun 5, 2023
mergify bot pushed a commit that referenced this issue Jun 5, 2023
@davidlearn @hhorii
Fix Renew example codes in README #1806: qiskit.providers.ibmq is dep…
b6cc4a2 
…recated; ibmq_athens is not available (#1831)

* Fix REAM #1896 qiskit.providers.ibmq is deprecated;

* In README example, simplify code to get aersim_backend

* Update README.md remove shots=1000

* use FakeManilaV2

* Update README.md import Fake backend in the beginning

* Update README.md remove unneeded IBM_Providers import.

---------

Co-authored-by: Hiroshi Horii <[email protected]>
@natestemen
Copy link

@hhorii please ensure this issue (and all other unitaryHACK issues) are assigned to the hacker who should receive the bounty upon closing. Looks to be @davidlearn in this case.

@davidlearn
Copy link
Contributor

davidlearn commented Jun 9, 2023 •
edited
Loading

Please assign this issue to me as required by unitaryHack organizers to keep track of who won the bounty. unitaryHack also has a leading board for all hackers who closes issues. Thank you.

@davidlearn
Copy link
Contributor

@1ucian0, please help with assigning the closed UnitrayHack issue to me. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidlearn davidlearn

Labels
documentation Something is not clear or error in description good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
6 participants
@natestemen @hhorii @andre-a-alves @Mostafa-Atallah2020 @davidlearn @alt-shreya