Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SamplerV2 and EstimatorV2 to be compatible with those of Qiskit 1.1 #2150

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Update SamplerV2 and EstimatorV2 to be compatible with those of Qiskit 1.1 #2150

merged 8 commits into from
Jun 14, 2024

Conversation

t-imamichi
Copy link
Member

@t-imamichi t-imamichi commented May 28, 2024 •
edited
Loading

Summary

Update SamplerV2 and EstimatorV2 to be compatible with Qiskit 1.1

  • SamplerV2 returns SamplerPubResult
  • They use DataBin class directly and stop using make_data_bin.
  • Removed np.random.Generator as seed because AerSimulator.run does not support it. (I think it never worked yet)

This PR updates the required Qiskit version to 1.1.0 because the above changes require Qiskit 1.1.

Note

  • SamplerV2 is based on BackendSamplerV2 of Qiskit.
  • EstimatorV2 is based on StatevectorEstimator of Qiskit because EstimatorV2 directly computes expectation values with save_expectation_value instruction instead of appending Pauli pre-rotations.

Details and comments

@doichanj doichanj added this to the Aer 0.15.0 milestone May 29, 2024
@t-imamichi t-imamichi force-pushed the primitives-v2 branch 2 times, most recently from 966f505 to 7fa2366 Compare May 29, 2024 06:26
@t-imamichi t-imamichi changed the title (WIP) Update SamplerV2 and EstimatorV2 to be compatible with those of Qiskit 1.1 Update SamplerV2 and EstimatorV2 to be compatible with those of Qiskit 1.1 May 29, 2024
@t-imamichi t-imamichi marked this pull request as ready for review May 29, 2024 08:37
@doichanj doichanj merged commit 7a4360f into Qiskit:main Jun 14, 2024
38 checks passed
@t-imamichi t-imamichi deleted the primitives-v2 branch June 14, 2024 09:08
@doichanj doichanj mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doichanj doichanj doichanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aer 0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t-imamichi @doichanj