Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Qiskit 1.2 #2201

Merged
merged 24 commits into from
Aug 15, 2024
Merged

Fixes for Qiskit 1.2 #2201

merged 24 commits into from
Aug 15, 2024

Conversation

doichanj
Copy link
Collaborator

@doichanj doichanj commented Aug 8, 2024

Summary

This PR is fixes for Qiskit 1.2

Details and comments

This PR includes

#2187 is also required for Qiskit 1.2 support

@doichanj doichanj added this to the Aer 0.15.0 milestone Aug 8, 2024
memory=False,
max_shots=int(1e6),
coupling_map=(
configuration = {
Copy link
Member

@t-imamichi t-imamichi Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a dataclass for configuration to avoid a breaking change.
It would be nice to raise a deprecation warning to access properties instead of an error.

backend  = AerSimulator()

# 0.14.2
backend.properties()  # None
backend.configuration().basis_gates # ['ccx',...]
backend.configuration()["basis_gates"]  # TypeError: 'QasmBackendConfiguration' object is not subscriptable

# this PR
backend.properties()  # AttributeError: 'AerSimulator' object has no attribute 'properties'
backend.configuration().basis_gates # AttributeError: 'dict' object has no attribute 'basis_gates'
backend.configuration()["basis_gates"]  # ['ccx',...]

@doichanj doichanj changed the title [WIP] Fixes for Qiskit 1.2 Fixes for Qiskit 1.2 Aug 14, 2024
@doichanj doichanj requested a review from hhorii August 14, 2024 09:27
@doichanj doichanj added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Deprecation Include in Deprecated section of changelog labels Aug 14, 2024
@doichanj doichanj added the Changelog: Bugfix Include in the Fixed section of the changelog label Aug 14, 2024
@doichanj doichanj merged commit 44bd7eb into Qiskit:main Aug 15, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog Changelog: Deprecation Include in Deprecated section of changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants