Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning descriptions with the VSCode extension #5

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

cbjuan
Copy link
Member

@cbjuan cbjuan commented Sep 15, 2024

Description

Adding some minor changes to texts to align them exactly to the VSCode extension

Type of change

Docs

How Has This Been Tested?

NA

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cbjuan cbjuan self-assigned this Sep 15, 2024
@cbjuan cbjuan added enhancement New feature or request documentation Improvements or additions to documentation labels Sep 15, 2024
Copy link
Collaborator

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One grammar nit, and is there a reason you're refreshing the yarn lock on a doc update? Is there a patch update we need to catch on some dependency? If not we should not update the yarn.lock (I believe it's breaking the CI build)

README-PyPi.md Outdated Show resolved Hide resolved
README-PyPi.md Outdated Show resolved Hide resolved
Co-authored-by: Alex Bozarth <[email protected]>
Copy link
Collaborator

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, do we need to cut a release for this or can it just go out the next time we release (I would assume in the next couple weeks when jupyterlab 4.3 releases)? If we need a release if you could increment to 0.3.2

@cbjuan
Copy link
Member Author

cbjuan commented Sep 17, 2024

Increased version to 0.3.2

@ajbozarth ajbozarth merged commit b6a76f1 into main Sep 17, 2024
6 checks passed
@ajbozarth ajbozarth deleted the jcb-description-improvements branch September 17, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants