SamplerV2 update #1420
Merged
SamplerV2 update #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8100319895Details
💛 - Coveralls |
|
Converting to draft as per @gadial's request. |
Closed
jyu00
reviewed
Feb 26, 2024
qiskit_ibm_runtime/sampler.py
Outdated
| @@ -42,7 +42,7 @@ class Sampler: | |||
| version = 0 | |||
|
|
|||
|
|
|||
| class SamplerV2(BasePrimitiveV2[SamplerOptions], Sampler, BaseSamplerV2): | |||
| class SamplerV2(BasePrimitiveV2, Sampler, BaseSamplerV2): | |||
There was a problem hiding this comment.
Why was SamplerOptions removed? It's meant to set the expected options class.
There was a problem hiding this comment.
Seems to me I accidently reverted to an older version. Will fix.
qiskit_ibm_runtime/sampler.py
Outdated
| @@ -148,23 +150,16 @@ class SamplerV1(BasePrimitiveV1, Sampler, BaseSampler): | |||
|
|
|||
| Example:: | |||
|
|
|||
| from qiskit.circuit import QuantumCircuit, QuantumRegister, ClassicalRegister | |||
| from qiskit.test.reference_circuits import ReferenceCircuits | |||
There was a problem hiding this comment.
qiskit.test no longer exists in 1.0
There was a problem hiding this comment.
Replaced with explicit code for generating bell circuit - is there a better alternative? Also, we have similar example in provider_session.py
jyu00
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Finalizes the
SamplerV2class and adds relevant tests.Replaces #1326
Details and comments
Fixes #1313
Most of the work required to run
SamplerV2was done in previous PR's and support for V2 containers inqiskitis now full, so this PR mainly addsSamplerV2to the Primitives V2 unit tests, and copies over theSamplerV2integration tests from qiskit.