Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the ISA check with validation of rzz angle #1953

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

yaelbh
Copy link
Collaborator

@yaelbh yaelbh commented Sep 26, 2024

Summary

During the ISA check, we check the angles of rzz gates, and verify that they are in the permitted range of [0, pi/2].

Details and comments

Fixes #1949.

@yaelbh
Copy link
Collaborator Author

yaelbh commented Sep 26, 2024

Note: the diff in the conf file, it is difficult to see it in the GitHub platform, it is the addition of the rzz gate to the set of basis gates (other fractional gates, like rzx, are already there).

@yaelbh yaelbh requested a review from kt474 September 26, 2024 12:28
@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Sep 26, 2024
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit 8b38d1e into Qiskit:main Sep 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that rzz angle is between 0 and pi/2
2 participants