Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Commit

Permalink
Fix tox -e docs for macOS (#1694)
Browse files Browse the repository at this point in the history
<!--
⚠️ If you do not respect this template, your pull request will be closed.
⚠️ Your pull request title should be short detailed and understandable for all.
⚠️ Also, please add it in the CHANGELOG file under Unreleased section.
⚠️ If your pull request fixes an open issue, please link to the issue.

✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.
-->

### Summary

`tox -e docs` now works on my M1.

### Details and comments

We now say to install `.[all]` in two places: before installing the package itself when just installing `deps`, and then again when installing the package itself. Tox uses the same venv for both times, so that essentially results in a no-op in the second stage. This is similar to Qiskit/qiskit#9758.
  • Loading branch information
Eric-Arellano authored Mar 29, 2023
1 parent e9b9b05 commit 2328636
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
minversion = 2.1
minversion = 3.15.0
envlist = py36, py37, py38, py39, py310, lint, docs
skipsdist = True

Expand Down Expand Up @@ -33,13 +33,18 @@ commands =
asv run {posargs}

[testenv:docs]
# Editable mode breaks macOS: https://github.com/sphinx-doc/sphinx/issues/10943
usedevelop = false
envdir = .tox/docs
passenv = DOCS_FROM_MASTER QISKIT_DOCS_BUILD_TUTORIALS QISKIT_ENABLE_ANALYTICS
extras =
all
deps =
-r requirements-dev.txt
sphinx-intl
# On macOS Tox 3.28, setting `extras` resulted in the package not being installed at all.
# It does not hurt to also install the package in the `deps` stage.
.[all]
commands =
sphinx-build -b html {posargs} -d {toxinidir}/docs/.doctrees {toxinidir}/docs/ {toxinidir}/docs/_build/html

Expand Down

0 comments on commit 2328636

Please sign in to comment.