Upgrade to qiskit-sphinx-theme 2.0.0 #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades to qiskit-sphinx-theme 2.0.0. It includes the Qiskit logo because the logo is no longer included in the theme. qiskit-sphinx-theme 2.0 supports dark mode as a new feature, so both light and dark versions of the logo are included.
garrison
force-pushed
the
sphinx-theme-2
branch
from
abb730b
to
bbcbfb8
Compare
This is a cropped version of the old Qiskit Ecosystem logo, taken from https://github.com/Qiskit/qiskit_sphinx_theme/blob/f968969f2f503efbcfe611bb11239157de427ad3/src/qiskit_sphinx_theme/theme/qiskit-sphinx-theme/static/images/ecosystem-logo.svg I created the dark mode version by hand-editing the resulting SVG file to use the color #d0d0d0, which matches the qiskit-sphinx-theme dark mode text color.
|
I'm done editing; I consider this ready to merge, and my immediate teammates seem happy with the appearance. |
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
Sep 4, 2024
This upgrades to qiskit-sphinx-theme 2.0.0. It includes the Qiskit logo because the logo is no longer included in the theme. qiskit-sphinx-theme 2.0 supports dark mode as a new feature, so both light and dark versions of the logo are included. This implements the same change as the PR at Qiskit/qiskit-serverless#1481.
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
Sep 6, 2024
This upgrades to qiskit-sphinx-theme 2.0.0. It includes the Qiskit logo because the logo is no longer included in the theme. qiskit-sphinx-theme 2.0 supports dark mode as a new feature, so both light and dark versions of the logo are included. This implements the same change as the PR at Qiskit/qiskit-serverless#1481.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This upgrades to qiskit-sphinx-theme 2.0.0. It includes the Qiskit logo because the logo is no longer included in the theme.
Details and comments
qiskit-sphinx-theme 2.0 supports dark mode as a new feature, so both light and dark versions of the logo are included.
Remaining action items