Don't add local gateway/media directory to container image #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul S. Schweigert <[email protected]> Fixes Qiskit#1473 The `gateway/media` directory is currently ignored by git. If the user happens to have created that directory locally for some reason (running tests?) then the docker build fails. This patch implements a simple fix for docker to ignore the local media diretory when building the container image.
psschwei
force-pushed
the
drop-gateway-media
branch
from
3830d94
to
7a25cd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul S. Schweigert [email protected]
Summary
Fixes #1473
The
gateway/mediadirectory is currently ignored by git. If the user happens to have created that directory locally for some reason (running tests?) then the docker build fails.This patch implements a simple fix to remove the local media diretory, if it exists, from the container image prior to the normal build steps.
Details and comments