Skip to content

Commit

Permalink
Install qiskit in ci env
Browse files Browse the repository at this point in the history
This commit ensures that we're actually installing qiskit in the travis
environment. Previously we were just running tests out of the qiskit
repo without installing it. This made things like testing jupyter or
external commands more difficult because we had to properly setup the
path to make sure the qiskit code was discoverable. This fixes that by
installing qiskit (in develop mode) so that the code is linked to the
python site-packages and is discoverable/importable by other python
packages on the system, regardless of where they're run from. This is
just a stopgap patch until we switch to using tox for ci, which will do
this for us as well.
  • Loading branch information
mtreinish committed Dec 13, 2018
1 parent 3062001 commit e1e03f2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ stage_generic: &stage_generic
- mkdir out && cd out && cmake $CMAKE_FLAGS ..
script:
# Compile the executables and run the tests.
- make && ARGS="-V" make test
- make && pip install -e .. && ARGS="-V" make test

stage_linux: &stage_linux
<<: *stage_generic
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
# Linter and style check (GNU/Linux, Python 3.5)
- stage: lint and pure python test
<<: *stage_linux_no_compile
script: make style VERBOSE="" && make lint VERBOSE=""
script: pip install . && make style VERBOSE="" && make lint VERBOSE=""

# Run the tests against without compilation (GNU/Linux, Python 3.5)
- stage: lint and pure python test
Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ install:
- pip.exe install stestr
# TODO(mtreinish): uncomment this when testing-cabal/subunit#33 is fixed
# - pip.exe install junitxml
- pip.exe install -e .

# Use py.test for output of xunit test results.
test_script:
Expand Down

0 comments on commit e1e03f2

Please sign in to comment.