-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disable_validation option to SymbolicPulse #11029
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
releasenotes/notes/symbolic-pulse-disable-validation-19cd8506b3a839b6.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
upgrade: | ||
- | | ||
Validation of :class:`qiskit.pulse.SymbolicPulse` objects can now be disabled. By setting | ||
the class attribute :attr:`qiskit.pulse.SymbolicPulse.disable_validation` to ``False`` | ||
the method :meth:`validate_parameters` will not be triggered for all `SymbolicPulse` objects. | ||
The automatic validation hindered JAX compatibility of the symbolic pulse library, and this | ||
upgrade will make it easier to use Qiskit Pulse with JAX. | ||
|
||
Note that all library pulses automatically called :meth:`validate_parameters`. However, as part | ||
of the upgrade the call was moved directly to the initialization process of | ||
:class:`qiskit.pulse.SymbolicPulse`. While this doesn't change the behaviour of library pulses, | ||
custom symbolic pulses which did not call :meth:`validate_parameters` will now trigger the | ||
method. The new class attribute will allow to easily disable this. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since argument is called
constraints
, something likeignore_constraints
is more intuitive?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkanazawa1989
The function is called
validate_parameters
so I went with that. Note that the function also validates the amplitude, and not just the constraints.