Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BaseEstimatorV2 #11527

Merged
merged 14 commits into from
Jan 17, 2024
Merged

Add BaseEstimatorV2 #11527

merged 14 commits into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. Add BaseEstimatorV2 class 

    Taken from 11227, but modified to
- remove options from BaseEstimatorV2
- add precision attribute to BaseEstimatorV2 and EstimatorPub
- remove BasePrimitiveV2 and BasePub

Co-Authored-By: Ikko Hamamura <[email protected]>
Co-Authored-By: Ian Hincks <[email protected]>
    @chriseclectic @ikkoham @ihincks
    3 people committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fcf531c View commit details
    Browse the repository at this point in the history

  2. Fix removal of BasePub

    @chriseclectic
    chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ab1c196 View commit details
    Browse the repository at this point in the history

  3. Remove precision from EstimatorPub

    @chriseclectic
    chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    25018f8 View commit details
    Browse the repository at this point in the history

  4. Add BaseEstimator._make_data_bin() static method

    @ihincks @chriseclectic
    ihincks authored and chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f178fb5 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Ian Hincks <[email protected]>
    @chriseclectic @ihincks
    chriseclectic and ihincks committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3cc901f View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Ian Hincks <[email protected]>
    @chriseclectic @ihincks
    chriseclectic and ihincks committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8a7155b View commit details
    Browse the repository at this point in the history

  7. linting

    @chriseclectic
    chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2b8bd60 View commit details
    Browse the repository at this point in the history

  8. Move precision to EstimatorPub and Estimator.run

    @chriseclectic
    chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2974d87 View commit details
    Browse the repository at this point in the history

  9. Update EstimatorV2 run return type, fix some typos

    @chriseclectic
    chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9706cda View commit details
    Browse the repository at this point in the history

  10. Fix some minor problems

    @ihincks @chriseclectic
    ihincks authored and chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    eaa7b10 View commit details
    Browse the repository at this point in the history

  11. add tests

    @ihincks @chriseclectic
    ihincks authored and chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bf6f934 View commit details
    Browse the repository at this point in the history

  12. Add * arg blocker, np.float -> np.float64

    @chriseclectic
    chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9a60b52 View commit details
    Browse the repository at this point in the history

  13. linting

    @chriseclectic
    chriseclectic committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c7dc30a View commit details
    Browse the repository at this point in the history

  14. add test for line of code changed in observables_array.py

    @ihincks
    ihincks committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    12c71e5 View commit details
    Browse the repository at this point in the history