Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of custom dt in transpile when target is provided #11995

Closed
wants to merge 2 commits into from
Closed

Fix use of custom dt in transpile when target is provided #11995

wants to merge 2 commits into from

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Mar 12, 2024 •
edited
Loading

Summary

Fixes #11994, I am not too sure if I should label it as a feature or a bugfix, I think it's both. This PR is currently blocking #11996.

Details and comments

@ElePT ElePT requested a review from a team as a code owner March 12, 2024 09:31
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@ElePT ElePT marked this pull request as draft March 12, 2024 09:32
@coveralls
Copy link

coveralls commented Mar 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8247453281

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 89.304%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 90.93%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 8232184462: 0.0%
Covered Lines: 59138
Relevant Lines: 66221
💛 - Coveralls

@ElePT ElePT mentioned this pull request Mar 12, 2024
Merged
@ElePT ElePT marked this pull request as ready for review March 12, 2024 10:42
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@ElePT ElePT mentioned this pull request Mar 12, 2024
Closed
@ElePT
Copy link
Contributor Author

ElePT commented Mar 19, 2024 •
edited
Loading

Superseded by #12042

@ElePT ElePT closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduling stage doesn't use custom dt when target provided
3 participants
@ElePT @qiskit-bot @coveralls