Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove qiskit.tools.logging #2387

Merged
merged 2 commits into from
May 10, 2019
Merged

remove qiskit.tools.logging #2387

merged 2 commits into from
May 10, 2019

Conversation

ajavadia
Copy link
Member

@ajavadia ajavadia commented May 9, 2019

Summary

closes #837

The loggers are stale code that have not been used. We rely on standard Python logging practices until a clear use case for this arises.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yeah this isn't directly used anywhere and it's just setting a logger at a fixed level. People should just use the default python logging interfaces to set this.

@ajavadia ajavadia merged commit b4af948 into Qiskit:master May 10, 2019
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_qiskit_logger() is hard to use
2 participants