Shorter controlled-hadamard definition #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
requested review from
1ucian0,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
lcapelluto,
mtreinish,
nonhermitian and
taalexander
as code owners
kdk
reviewed
Jul 30, 2019
| [0, 1, 0, 0], | ||
| [0, 0, 0.707, 0.707], | ||
| [0, 0, 0.707, -0.707]], dtype=complex) | ||
|
|
There was a problem hiding this comment.
We should verify the indexing here, and make sure to get enough precision to pass e.g. np.isclose.
There was a problem hiding this comment.
@kdk I fixed this and added a test. Thanks for the good catch.
ajavadia
force-pushed
the
ch-shorter
branch
2 times, most recently
from
e6533d8
to
d3f8657
Compare
nonhermitian
approved these changes
Aug 22, 2019
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* shorter CH gate definition * changelog * add ch matrix * import numpy * add test * fix broken test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shorter definition for the ch gate, based on #1741