Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing pluggable HighLevelSynthesis #8548
Implementing pluggable HighLevelSynthesis #8548
Changes from 3 commits
e62c79e
530ac33
975d0de
f2e1380
c139421
dea4544
2d55fa4
51acb33
b0f8c87
a63d112
15e22b7
e52eb16
206d87e
ba0edb5
0fd32f2
6abbf07
9b28157
233d798
3d06999
b625cc5
4186bb2
4abaff3
8a38922
054125b
738ed62
def3b50
4f6c95c
0ffd981
5fa8387
bb680ca
5b382e0
9c06042
af9d498
517007b
bda0ac4
ed35b50
ba96369
f65cfac
5cee799
cba889d
9e22d1b
0a41fba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be part of
qiskit/transpiler/passes/synthesis/plugin.py
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also makes sense, especially if we want to generalize the documentation to cover both cases. Though let me redirect this question to @mtreinish, to see if he agrees with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this idea, we should integrate the docs into one module docstring. I think the details are sufficiently different we'll want 2 sections for each interface, mostly because implementing the plugins are different. But the pieces about using entry points to expose plugins are sufficiently the same we can abstract that if you think it's best. FWIW, this is why the section hierarchy has the top header as
Writing Plugins
and the subsection isUnitary Synthesis Plugins
. My thinking at the time was we could easily add any other synthesis interfaces to that list with a new subsection. So in this case addHigh Level Synthesis
as a subsection thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (see the previous comment for more details).