Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing test coverage for RZXCalibration builder with target #9416

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add missing test coverage for RZXCalibration builder with target #9416

merged 2 commits into from
Jan 23, 2023

Commits on Jan 23, 2023

  1. Add missing test coverage for RZXCalibration builder with target 

    In the recently merged Qiskit#9343 support for using the Target directly was
added to the RZXCalibrartionBuilder family of passes. However, test
coverage in that PR was omitted by mistake for that pass (other passes
in the PR were covered). There was a bug in the code change introduced
in that PR which caused an error on initialization if a target were
specified without an InstructionScheduleMap (which was the intent of the
new target kwarg). This commit fixes the logic bug in the pass and adds
test coverage to ensure specifying only a target continues to work
moving forward.
    @mtreinish
    mtreinish committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    93e96c4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-rzx-cal-build-target

    @mergify
    mergify[bot] authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    59710f8 View commit details
    Browse the repository at this point in the history