Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthesis of CZ and Clifford circuits for linear nearest neighbor connectivity #9450
Synthesis of CZ and Clifford circuits for linear nearest neighbor connectivity #9450
Changes from 21 commits
d124098
ca8bd61
3cc7ec0
d054b20
4811701
2e80042
83b0ba3
065f63b
25e094a
96884dd
6654529
e6e955c
f3949d5
a5570f1
ea28360
71a2416
fe0e0a3
9ed42e1
d00cf99
134d3f4
7924796
8e30f2e
29e90b3
dfb4d38
b918685
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion on this either. Does it make sense that code for CZ synthesis appears under
linear
? Or would it be better to put it in thesynthesis/cz
subdirectory?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best solution is to have another folder of
synthesis/linear_phase
since the cz synthesis is into cx and phase gates, and relies on the theory of phase polynomials. It's similar tograysynth
that should be moved this folder too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving and renaming
graysynth
, as well as deprecatinghttps://github.com/Qiskit/qiskit-terra/blob/main/qiskit/transpiler/synthesis/graysynth.py
will be done in a separate PR