Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new deprecation decorators to circuit folder #9869
Apply new deprecation decorators to circuit folder #9869
Changes from 9 commits
4a239a9
55c988d
928f739
54f6ee8
de64cde
8defcee
1122627
ad77552
3988b33
e1f2381
23c19f1
c248e9e
5400750
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, the comment is still true lol. It's fine to get rid of it, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nitpicky, but the parenthetical sentences here end up being longer than the actual deprecation message, which feels pretty weird to me. It's either important information for the user, in which case it needn't be parenthesised, or it's not and it can be a code/docs-only comment instead. I don't particularly mind which.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only semi-related: the error message we've got here shows a potential place for improvement in the decorators to me;
qiskit.circuit.bit.Bit.register
feels way too long to put out. I thinkBit.register
would be less noisy - the user will always be able to inspect the object themselves if they need to know more about it.