Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new deprecation decorators to qobj and qpy #9870

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Apply new deprecation decorators to qobj and qpy #9870

merged 1 commit into from
Mar 30, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Mar 29, 2023 •
edited
Loading

Summary

See #9676 for the motivation.

Details and comments

@Eric-Arellano Eric-Arellano added the Changelog: None Do not include in changelog label Mar 29, 2023
@Eric-Arellano Eric-Arellano requested a review from a team as a code owner March 29, 2023 14:55
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4555444844

  • 27 of 27 (100.0%) changed or added relevant lines in 5 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 85.374%
Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
crates/accelerate/src/sabre_swap/layer.rs 4 97.32%
Totals Coverage Status
Change from base Build 4552100985: 0.03%
Covered Lines: 67244
Relevant Lines: 78764
💛 - Coveralls

nkanazawa1989
nkanazawa1989 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Mar 30, 2023
Merged via the queue into Qiskit:main with commit a50fe82 Mar 30, 2023
@1ucian0 1ucian0 added the type: qa Issues and PRs that relate to testing and code quality label Mar 30, 2023
@Eric-Arellano Eric-Arellano deleted the apply-deprecations-qobj branch March 30, 2023 11:42
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Apr 5, 2023
@Eric-Arellano @ElePT
Apply new deprecation decorators to qobj and qpy (Qiskit#9870)
1735933
giacomoRanieri pushed a commit to giacomoRanieri/qiskit-terra that referenced this pull request Apr 16, 2023
@Eric-Arellano @giacomoRanieri
Apply new deprecation decorators to qobj and qpy (Qiskit#9870)
31a3191
@jakelishman jakelishman mentioned this pull request Apr 19, 2023
Closed
10 tasks
This was referenced May 3, 2023
Merged
Merged
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
@Eric-Arellano @king-p3nguin
Apply new deprecation decorators to qobj and qpy (Qiskit#9870)
7b606bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkanazawa1989 nkanazawa1989 nkanazawa1989 approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Eric-Arellano @qiskit-bot @coveralls @nkanazawa1989 @1ucian0