Add minimumWheelLightness #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly thanks for this library. It's great!
I'm using it as a text color picker. The default text color is black. The problem I had was when the user opens the text color picker for the first time, all the circles on the wheel were black as the wheel was set to the current text color. Users had to drag the lightness slider before revealing the colors they can choose from which wasn't intuitive.
This PR tackles this problem by adding an optional attribute to the ColorPickerView which will show the wheel colors at full lightness, except for the circle currently selected, when the lightness value drops below it. The idea is that when the lightness value is as low as 0.01 for example, the colors are indistinguishable so offering lots of buttons that effectively do the same thing is not that useful.
Hopefully this will help others too (#109)
I also made changes to get this building with Jitpack